This repository has been archived by the owner on Dec 1, 2021. It is now read-only.
Fix a stability about multiple measurements #1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR needs Approvals as follows.
Please choose reviewers and requet reviews! Click to see how to approve each reviewsYou can approve this PR by triggered comments as follows.
See all trigger commentsPlease replace [Target] to review target
|
|
This log is from original |
|
This is a log from improved |
|
iizukak
approved these changes
Apr 22, 2020
output_template/python/run.py
Outdated
| @@ -93,12 +96,12 @@ def _init(model, config): | |||
| return nn | |||
|
|
|||
|
|
|||
| def _run(nn, image_data): | |||
| def _run(image_data, nn): | |||
There was a problem hiding this comment.
Sorry, I missed this line.
Why did change order of arguments?
There was a problem hiding this comment.
I changed this line because the similar functions (_pre_process, _run, _post_process) should have same order of argument.
But when I checked my code again, my current code is also not so ruled that I can recover original code.
There was a problem hiding this comment.
@iizukak
The changing order has been recovered to original code
iizukak
reviewed
Apr 27, 2020
output_template/python/run.py
Outdated
| "pre": {"mean": np.mean(results_pre), "std": np.std(results_pre), }, | ||
| "post": {"mean": np.mean(results_post), "std": np.std(results_post), }, | ||
| "run": {"mean": np.mean(results_run), "std": np.std(results_run), }, | ||
| }, |
There was a problem hiding this comment.
@tk26eng Sorry, I missed this.
This line looks return tuple. This is what you want?
In [1]: a = {"a": 0, "b": 1}
In [2]: b = {"a": 0, "b": 1},
In [3]: type(a)
Out[3]: dict
In [4]: type(b)
Out[4]: tuple
There was a problem hiding this comment.
Thank you.
Dict type is what I wanted to use.
I fixed this.
There was a problem hiding this comment.
@iizukak
Can I go to Readability Review ?
tfujiwar
reviewed
Apr 30, 2020
output_template/python/run.py
Outdated
|
|
||
| # add the batch dimension | ||
| image_data = np.expand_dims(image_data, axis=0) | ||
| funcs = [(_pre_process, image_data), _run, _post_process] |
There was a problem hiding this comment.
funcs seems not to be used.
Co-authored-by: Taketoshi Fujiwara <[email protected]>
Co-authored-by: Taketoshi Fujiwara <[email protected]>
Co-authored-by: Taketoshi Fujiwara <[email protected]>
Co-authored-by: Taketoshi Fujiwara <[email protected]>
|
/ready |
|
⏳Merge job is queued... |
|
😥This PR is not approved yet. |
tfujiwar
changed the title
tfujiwar
changed the title
|
/ready |
|
⏳Merge job is queued... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this patch does to fix the issue.
Link to any relevant issues or pull requests.
Fix #929