Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Add table support in markdown (.md) file #1004

Merged
merged 2 commits into from
Apr 22, 2020
Merged

Add table support in markdown (.md) file #1004

merged 2 commits into from
Apr 22, 2020

Conversation

oatawa1
Copy link
Contributor

@oatawa1 oatawa1 commented Apr 17, 2020

What this patch does to fix the issue.

This commit add sphinx-markdown-tables to blueoil document in order to have table compatible in a markdown file.

https://pypi.org/project/sphinx-markdown-tables/

Link to any relevant issues or pull requests.

Closes #1003

@oatawa1 oatawa1 added enhancement New feature or request documentation dependencies Pull requests that update a dependency file labels Apr 17, 2020
@oatawa1 oatawa1 requested a review from iizukak April 17, 2020 13:52
@oatawa1 oatawa1 self-assigned this Apr 17, 2020
@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Apr 17, 2020
@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Ownership Approval for / from iizukak, tkng, ruimashita
  • Readability Approval for Python from tkng, tsawada, tfujiwar

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python

  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

@oatawa1 oatawa1 mentioned this pull request Apr 17, 2020
Merged
iizukak
iizukak approved these changes Apr 22, 2020
View reviewed changes
Copy link
Member

@iizukak iizukak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ownership Approval
Thanks.

@oatawa1
Copy link
Contributor Author

oatawa1 commented Apr 22, 2020

@iizukak Thank you.

@oatawa1 oatawa1 requested a review from tfujiwar April 22, 2020 01:23
tfujiwar
tfujiwar approved these changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@tfujiwar tfujiwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readability Approval

@oatawa1
Copy link
Contributor Author

oatawa1 commented Apr 22, 2020

@tfujiwar Thank you.

@oatawa1
Copy link
Contributor Author

oatawa1 commented Apr 22, 2020

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Apr 22, 2020

⏳Merge job is queued...

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Apr 22, 2020

😥Status check failed. Please fix problems and send /ready again.

@oatawa1 oatawa1 added the CI: test-blueoil Run blueoil test once label Apr 22, 2020
@blueoil-butler blueoil-butler bot removed the CI: test-blueoil Run blueoil test once label Apr 22, 2020
@oatawa1 oatawa1 added the CI: test-all Run all tests once label Apr 22, 2020
@blueoil-butler blueoil-butler bot removed the CI: test-all Run all tests once label Apr 22, 2020
@oatawa1 oatawa1 added the CI: test-blueoil Run blueoil test once label Apr 22, 2020
@blueoil-butler blueoil-butler bot removed the CI: test-blueoil Run blueoil test once label Apr 22, 2020
@oatawa1
Copy link
Contributor Author

oatawa1 commented Apr 22, 2020

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Apr 22, 2020

⏳Merge job is queued...

@bo-mergebot bo-mergebot bot merged commit 01d67e0 into blue-oil:master Apr 22, 2020
@oatawa1 oatawa1 deleted the table-md-support branch April 22, 2020 03:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iizukak iizukak iizukak approved these changes

@tfujiwar tfujiwar tfujiwar approved these changes

Assignees

@oatawa1 oatawa1

Labels
CI: auto-run Run CI automatically dependencies Pull requests that update a dependency file documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support table in markdown file
3 participants
@oatawa1 @iizukak @tfujiwar