-
Notifications
You must be signed in to change notification settings - Fork 86
Conversation
This PR needs Approvals as follows.
Please choose reviewers and requet reviews! Click to see how to approve each reviewsYou can approve this PR by triggered comments as follows.
See all trigger commentsPlease replace [Target] to review target
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Readability Approval
Thanks for expanding TFDS datasets!!
description="Custom TFDS dataset for segmentation", | ||
features=tfds.features.FeaturesDict({ | ||
"image": tfds.features.Image(), | ||
"label": tfds.features.ClassLabel(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the feature label
is used for having a list of classes but not needed for every example. Is my understanding correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tfujiwar
Yes! Your understanding is correct! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OA
/ready |
⏳Merge job is queued... |
What this patch does to fix the issue.
Close #1002
Link to any relevant issues or pull requests.
Refs
I referred to the official tutorial of segmentation to decide the TFDS feature format. (
image
,label
,segmentation_mask
)https://www.tensorflow.org/tutorials/images/segmentation#download_the_oxford-iiit_pets_dataset