Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Change available_subsets as a class variable #1008

Merged
merged 2 commits into from
Apr 22, 2020
Merged

Change available_subsets as a class variable #1008

merged 2 commits into from
Apr 22, 2020

Conversation

hadusam
Copy link
Contributor

@hadusam hadusam commented Apr 20, 2020

What this patch does to fix the issue.

Fix #1007

Link to any relevant issues or pull requests.

@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Apr 20, 2020
@hadusam hadusam requested a review from iizukak April 20, 2020 09:42
@hadusam hadusam self-assigned this Apr 20, 2020
iizukak
iizukak approved these changes Apr 22, 2020
View reviewed changes
Copy link
Member

@iizukak iizukak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OA

@hadusam hadusam requested a review from tfujiwar April 22, 2020 02:47
tfujiwar
tfujiwar approved these changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@tfujiwar tfujiwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readability Approval

@hadusam
Copy link
Contributor Author

hadusam commented Apr 22, 2020

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Apr 22, 2020

⏳Merge job is queued...

@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Ownership Approval for / from iizukak, tkng, ruimashita
  • Readability Approval for Python from tkng, tsawada, tfujiwar

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python

  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

@bo-mergebot bo-mergebot bot merged commit c5cd1aa into blue-oil:master Apr 22, 2020
@hadusam hadusam mentioned this pull request Apr 22, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iizukak iizukak iizukak approved these changes

@tfujiwar tfujiwar tfujiwar approved these changes

Assignees

@hadusam hadusam

Labels
CI: auto-run Run CI automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

available_subsets are used as class variable and instance property
3 participants
@hadusam @iizukak @tfujiwar