Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Clean Up Makefile of Runtime #1013

Merged
merged 6 commits into from
Apr 30, 2020
Merged

Conversation

tk26eng
Copy link
Contributor

@tk26eng tk26eng commented Apr 28, 2020

What this patch does to fix the issue.

  • This patch cleans up Makefile of runtime
  • This enables easier way to add the new supported architecture
  • The options for make is also changed
  • This add new feature and it can detect changed header file correctly

Link to any relevant issues or pull requests.

Fix #1006

@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Apr 28, 2020
@tk26eng tk26eng self-assigned this Apr 28, 2020
@tk26eng tk26eng marked this pull request as ready for review April 28, 2020 13:06
@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Ownership Approval for / from iizukak, tkng, ruimashita
  • Readability Approval for Python from tkng, tsawada, tfujiwar

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python
  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

@tk26eng tk26eng requested a review from iizukak April 28, 2020 13:06
Copy link
Member

@iizukak iizukak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OA
Nice refactoring

@tk26eng tk26eng requested review from primenumber and tfujiwar April 28, 2020 13:49
@tk26eng
Copy link
Contributor Author

tk26eng commented Apr 28, 2020

@primenumber
@tfujiwar
This code includes changes of Makefile and some python code.
Could you review this PR ?

Copy link
Contributor

@tfujiwar tfujiwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readability Approval for Python

Copy link
Contributor

@primenumber primenumber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tk26eng
Copy link
Contributor Author

tk26eng commented Apr 30, 2020

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Apr 30, 2020

⏳Merge job is queued...

@bo-mergebot bo-mergebot bot merged commit 1454801 into blue-oil:master Apr 30, 2020
@tk26eng tk26eng deleted the update_makefile branch April 30, 2020 13:14
@tk26eng
Copy link
Contributor Author

tk26eng commented May 1, 2020

Fix #436

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI: auto-run Run CI automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Makefile
4 participants