Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Replace deprecated np.asscalar() with np.ndarray.item() #1022

Merged
merged 2 commits into from
May 8, 2020
Merged

Replace deprecated np.asscalar() with np.ndarray.item() #1022

merged 2 commits into from
May 8, 2020

Conversation

tfujiwar
Copy link
Contributor

@tfujiwar tfujiwar commented May 7, 2020

What this patch does to fix the issue.

To Suppress several hundreds of lines of warning messages.

https://buildkite.com/blueoil/dlk-test/builds/2640#e08ef65c-f4e8-494c-b2ed-e242af5106e1

blueoil/converter/core/operators.py:1450
...
blueoil/converter/core/operators.py:1450
  /home/blueoil/blueoil/converter/core/operators.py:1450: DeprecationWarning: np.asscalar(a) is deprecated since NumPy v1.16, use a.item() instead
    return np.asscalar(self._input_ops['Z'].data)

@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label May 7, 2020
@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Ownership Approval for / from iizukak, tkng, ruimashita

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python
  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

@tfujiwar tfujiwar requested a review from iizukak May 7, 2020 01:20
Copy link
Member

@iizukak iizukak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OA

@iizukak
Copy link
Member

iizukak commented May 8, 2020

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented May 8, 2020

⏳Merge job is queued...

@bo-mergebot bo-mergebot bot merged commit 73be38e into blue-oil:master May 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI: auto-run Run CI automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants