-
Notifications
You must be signed in to change notification settings - Fork 86
Remove deprecated properties from dataset class #1025
Remove deprecated properties from dataset class #1025
Conversation
This PR needs Approvals as follows.
Please choose reviewers and requet reviews! Click to see how to approve each reviewsYou can approve this PR by triggered comments as follows.
See all trigger commentsPlease replace [Target] to review target
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cleaning up.
def _get_index(self, counter): | ||
return self.indices[counter] | ||
|
||
def _shuffle(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method is called in dataset_iterator.py
but I think it's not needed. Could you refactor it also?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Good refactoring.
OA
fefd97d
to
0fa476a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Readability Approval
Thank you!
What this patch does to fix the issue.
Remove some deprecated properties from dataset class. These feature will be done in
blueoil/blueoil/datasets/dataset_iterator.py
Lines 287 to 363 in e578430
Link to any relevant issues or pull requests.