Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Optimize binary operation for converter runtime #1027

Merged
merged 1 commit into from
May 13, 2020

Conversation

primenumber
Copy link
Contributor

What this patch does to fix the issue.

This PR improve performance for binary operator, if the shape of inner dimension is same between left hand side and right hand side.

Link to any relevant issues or pull requests.

#702

@primenumber primenumber added the enhancement New feature or request label May 11, 2020
@primenumber primenumber requested a review from iizukak May 11, 2020 08:17
@primenumber primenumber self-assigned this May 11, 2020
@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label May 11, 2020
@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Ownership Approval for / from iizukak, tkng, ruimashita

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python
  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

Copy link
Member

@iizukak iizukak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OA

@iizukak
Copy link
Member

iizukak commented May 13, 2020

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented May 13, 2020

⏳Merge job is queued...

@bo-mergebot bo-mergebot bot merged commit aa7ee6f into blue-oil:master May 13, 2020
@primenumber primenumber deleted the opti-bin-op branch September 29, 2021 05:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI: auto-run Run CI automatically enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants