Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Add PerImageStandardization compatibility in (C++ inference) runtime #1031

Merged

Conversation

oatawa1
Copy link
Contributor

@oatawa1 oatawa1 commented May 14, 2020

What this patch does to fix the issue.

The PerImageStandardization is already implemented but it is not in the mapping process.
This PR adds mapping process node to functions vector.

Link to any relevant issues or pull requests.

#1020 (comment)

@oatawa1 oatawa1 requested a review from iizukak May 14, 2020 07:35
@oatawa1 oatawa1 self-assigned this May 14, 2020
@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label May 14, 2020
@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Ownership Approval for / from iizukak, tkng, ruimashita
  • Readability Approval for C++ from tkng, tsawada, primenumber

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python
  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

@oatawa1 oatawa1 mentioned this pull request May 14, 2020
5 tasks
@iizukak
Copy link
Member

iizukak commented May 15, 2020

@oatawa1
How about to add unit test?
Maybe here
https://github.com/blue-oil/blueoil/blob/master/runtime/test/test_data_processor.cpp

@oatawa1
Copy link
Contributor Author

oatawa1 commented May 15, 2020

@iizukak great idea. Let's me try.

Copy link
Member

@iizukak iizukak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OA
We need C++ readability reviewer

@oatawa1
Copy link
Contributor Author

oatawa1 commented May 18, 2020

@iizukak Thank you. I will proceed with this PR.

The unit test will add in PR #1037.

@primenumber
Copy link
Contributor

RA 👍

@oatawa1
Copy link
Contributor Author

oatawa1 commented May 18, 2020

@primenumber Thank you.

@oatawa1
Copy link
Contributor Author

oatawa1 commented May 18, 2020

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented May 18, 2020

⏳Merge job is queued...

@bo-mergebot bo-mergebot bot merged commit 72c203a into blue-oil:master May 18, 2020
@oatawa1 oatawa1 deleted the PerImageStandardization-compat-runtime branch May 19, 2020 02:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI: auto-run Run CI automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants