Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Update PYTHONPATH for main.py in document #1050

Merged
merged 3 commits into from
Jun 1, 2020

Conversation

oatawa1
Copy link
Contributor

@oatawa1 oatawa1 commented May 26, 2020

What this patch does to fix the issue.

Some documents under blueoil/docs/usage directory refer to obsolete PYTHONPATH.
This PR update the PYTHONPATH.

Link to any relevant issues or pull requests.

Closes #1046

@oatawa1 oatawa1 requested a review from iizukak May 26, 2020 09:16
@oatawa1 oatawa1 self-assigned this May 26, 2020
@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label May 26, 2020
@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Ownership Approval for / from iizukak, tkng, ruimashita

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python
  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

@iizukak
Copy link
Member

iizukak commented May 27, 2020

@oatawa1 In my understand, We do not need PYTHONPATH anymore.

@oatawa1
Copy link
Contributor Author

oatawa1 commented May 28, 2020

@iizukak
I agree I think we don't need it when we install blueoil via pip -e .[cpu] or pip -e .[gpu],

But if we manually install the package via pip, we may need it. Precisely only PYTHONPATH=.
If not it will throw this error.

Traceback (most recent call last):
  File "blueoil/cmd/main.py", line 21, in <module>
    from blueoil.cmd.convert import convert as run_convert
ModuleNotFoundError: No module named 'blueoil'

My solution will be update the document about installation because we currently don't have it and remove PYTHONPATH from this PR.

Copy link
Member

@iizukak iizukak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OA

@iizukak
Copy link
Member

iizukak commented Jun 1, 2020

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Jun 1, 2020

⏳Merge job is queued...

@oatawa1
Copy link
Contributor Author

oatawa1 commented Jun 1, 2020

@iizukak Thank you.

@bo-mergebot bo-mergebot bot merged commit d18a9b4 into blue-oil:master Jun 1, 2020
@oatawa1 oatawa1 deleted the fix-python-path branch June 5, 2020 07:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI: auto-run Run CI automatically documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong PYTHONPATH in some documents
2 participants