Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Remove unused inheritance #1054

Merged
merged 1 commit into from
May 27, 2020
Merged

Conversation

primenumber
Copy link
Contributor

What this patch does to fix the issue.

Link to any relevant issues or pull requests.

@primenumber primenumber requested a review from iizukak May 26, 2020 11:05
@primenumber primenumber self-assigned this May 26, 2020
@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label May 26, 2020
@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Ownership Approval for / from iizukak, tkng, ruimashita
  • Readability Approval for Python from tkng, tsawada, tfujiwar

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python
  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

@tkng
Copy link
Contributor

tkng commented May 27, 2020

RA
OA

@tkng
Copy link
Contributor

tkng commented May 27, 2020

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented May 27, 2020

⏳Merge job is queued...

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented May 27, 2020

😥Not mergeable. Please fix problems and send /ready again.

@tkng tkng self-requested a review May 27, 2020 12:20
@tkng
Copy link
Contributor

tkng commented May 27, 2020

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented May 27, 2020

⏳Merge job is queued...

@bo-mergebot bo-mergebot bot merged commit 2b0d7c0 into blue-oil:master May 27, 2020
@primenumber primenumber deleted the fix-inherit branch May 27, 2020 12:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI: auto-run Run CI automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants