Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Added test_image option to convert command. #1056

Merged
merged 2 commits into from
Jun 1, 2020
Merged

Added test_image option to convert command. #1056

merged 2 commits into from
Jun 1, 2020
+18 −11

Conversation

odoku
Copy link
Contributor

@odoku odoku commented May 27, 2020

What this patch does to fix the issue.

#960

@odoku odoku requested review from suttang, iizukak and tfujiwar May 27, 2020 02:32
@odoku odoku self-assigned this May 27, 2020
@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label May 27, 2020
@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Ownership Approval for / from iizukak, tkng, ruimashita
  • Readability Approval for Python from tkng, tsawada, tfujiwar

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python

  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

@odoku odoku force-pushed the add-test-image-option-to-convert branch from 0ada795 to 4404a32 Compare May 27, 2020 07:08
iizukak
iizukak reviewed May 27, 2020
View reviewed changes
Copy link
Member

@iizukak iizukak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@suttang Please check this PR will solve your issue.

blueoil/cmd/convert.py
@@ -137,6 +137,7 @@ def run(experiment_id,
output_template_dir=None,
image_size=(None, None),
project_name=None,
test_image=DEFAULT_INFERENCE_TEST_DATA_IMAGE,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change docstring.

tfujiwar
tfujiwar approved these changes May 28, 2020
View reviewed changes
Copy link
Contributor

@tfujiwar tfujiwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RA

@odoku odoku requested a review from iizukak May 28, 2020 04:38
iizukak
iizukak approved these changes Jun 1, 2020
View reviewed changes
Copy link
Member

@iizukak iizukak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OA

@iizukak
Copy link
Member

iizukak commented Jun 1, 2020

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Jun 1, 2020

😥Not mergeable. Please fix problems and send /ready again.

@iizukak
Copy link
Member

iizukak commented Jun 1, 2020

wow
@odoku Sorry, blueoil/cmd/main.py conflicted...

suttang
suttang approved these changes Jun 1, 2020
View reviewed changes
Copy link
Contributor

@suttang suttang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@odoku @iizukak Once resolved. Thank you very much.

@odoku odoku force-pushed the add-test-image-option-to-convert branch from f0852ab to 4107675 Compare June 1, 2020 05:00
@odoku
Copy link
Contributor Author

odoku commented Jun 1, 2020

@iizukak I solved the conflict!!!

@iizukak iizukak merged commit b90dabd into blue-oil:master Jun 1, 2020
@odoku odoku deleted the add-test-image-option-to-convert branch June 2, 2020 03:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@suttang suttang suttang approved these changes

@iizukak iizukak iizukak approved these changes

@tfujiwar tfujiwar tfujiwar approved these changes

Assignees

@odoku odoku

Labels
CI: auto-run Run CI automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@odoku @iizukak @suttang @tfujiwar