Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Refactor cpp code #1071

Merged
merged 7 commits into from
Jun 9, 2020
Merged

Refactor cpp code #1071

merged 7 commits into from
Jun 9, 2020

Conversation

lm-noshiro
Copy link
Contributor

@lm-noshiro lm-noshiro commented May 29, 2020 •
edited
Loading

What this patch does to fix the issue.

  • removed redundant flush immediately after endl
  • use empty() instead of size() == 0
  • reduce recalculation

Link to any relevant issues or pull requests.

@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label May 29, 2020
@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Ownership Approval for / from iizukak, tkng, ruimashita
  • Readability Approval for C++ from tkng, tsawada, primenumber

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python

  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

@lm-noshiro lm-noshiro self-assigned this May 29, 2020
@lm-noshiro lm-noshiro requested a review from iizukak May 29, 2020 07:34
iizukak
iizukak approved these changes Jun 1, 2020
View reviewed changes
Copy link
Member

@iizukak iizukak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OA

@iizukak iizukak requested a review from primenumber June 2, 2020 01:29
primenumber
primenumber approved these changes Jun 2, 2020
View reviewed changes
Copy link
Contributor

@primenumber primenumber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RA

@primenumber
Copy link
Contributor

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Jun 2, 2020

⏳Merge job is queued...

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Jun 2, 2020

😥Status check failed. Please fix problems and send /ready again.

@iizukak iizukak added the CI: test-all Run all tests once label Jun 3, 2020
@blueoil-butler blueoil-butler bot removed the CI: test-all Run all tests once label Jun 3, 2020
@iizukak
Copy link
Member

iizukak commented Jun 3, 2020

@kchygoe @tfujiwar
make build failed in CI.
Do you have any idea?
https://buildkite.com/blueoil/dlk-test/builds/2779#3aa45ba7-6ccd-4601-8e15-5fe8c35a203f

@kchygoe
Copy link
Member

kchygoe commented Jun 3, 2020

let me check the test env

@kchygoe
Copy link
Member

kchygoe commented Jun 3, 2020

@iizukak Resolved test. It works correctly now. sorry for the inconvenience.

@iizukak
Copy link
Member

iizukak commented Jun 3, 2020

@kchygoe Thanks 🙇

@iizukak
Copy link
Member

iizukak commented Jun 9, 2020

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Jun 9, 2020

⏳Merge job is queued...

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Jun 9, 2020

😥This PR is not approved yet.

@iizukak
Copy link
Member

iizukak commented Jun 9, 2020

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Jun 9, 2020

⏳Merge job is queued...

@bo-mergebot bo-mergebot bot merged commit 5335950 into blue-oil:master Jun 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iizukak iizukak iizukak approved these changes

@primenumber primenumber primenumber approved these changes

Assignees

@lm-noshiro lm-noshiro

Labels
CI: auto-run Run CI automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lm-noshiro @primenumber @iizukak @kchygoe