Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Fix checking pad #1085

Merged
merged 3 commits into from
Jun 11, 2020
Merged

Fix checking pad #1085

merged 3 commits into from
Jun 11, 2020

Conversation

primenumber
Copy link
Contributor

What this patch does to fix the issue.

correct order: [top, bottom, left, right]
(it is same as tf.pad)

Link to any relevant issues or pull requests.

@primenumber primenumber added the bug Something isn't working label Jun 9, 2020
@primenumber primenumber self-assigned this Jun 9, 2020
@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Jun 9, 2020
@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Ownership Approval for / from iizukak, tkng, ruimashita
  • Readability Approval for Python from tkng, tsawada, tfujiwar

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python

  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

@primenumber primenumber requested review from iizukak and tfujiwar June 9, 2020 09:10
tfujiwar
tfujiwar approved these changes Jun 9, 2020
View reviewed changes
Copy link
Contributor

@tfujiwar tfujiwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RA

iizukak
iizukak reviewed Jun 10, 2020
View reviewed changes
tests/converter/test_consistency_check.py
@@ -114,7 +114,7 @@ def test_conv_consistency(self) -> None:
[1, 3, 3, 3],
Float32(),
input_ops,
pads=[1, 1, 2, 2],
pads=[1, 2, 1, 2],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I can not understand this change clearly.
pad format is [top, bottom, left, right] and this line means using different padding value for top and buttom. right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

iizukak
iizukak approved these changes Jun 11, 2020
View reviewed changes
Copy link
Member

@iizukak iizukak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OA

@iizukak
Copy link
Member

iizukak commented Jun 11, 2020

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Jun 11, 2020

⏳Merge job is queued...

@bo-mergebot bo-mergebot bot merged commit 4d84a82 into blue-oil:master Jun 11, 2020
@primenumber primenumber deleted the fix-check-pad branch June 11, 2020 04:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iizukak iizukak iizukak approved these changes

@tfujiwar tfujiwar tfujiwar approved these changes

Assignees

@primenumber primenumber

Labels
bug Something isn't working CI: auto-run Run CI automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@primenumber @iizukak @tfujiwar