Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Fix license header consistency #1093

Merged
merged 2 commits into from
Jun 19, 2020
Merged

Conversation

oatawa1
Copy link
Contributor

@oatawa1 oatawa1 commented Jun 15, 2020

What this patch does to fix the issue.

Target files are *.py, *.cpp, *.h, *.hpp

  • Add missing header license to all target file
  • Fix consistency of no. of = in the last line of license to 77. There are 78 for some of C++ src and header files.

Link to any relevant issues or pull requests.

@oatawa1 oatawa1 requested a review from iizukak June 15, 2020 07:53
@oatawa1 oatawa1 self-assigned this Jun 15, 2020
@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Jun 15, 2020
@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Ownership Approval for / from iizukak, tkng, ruimashita
  • Readability Approval for Python from tkng, tsawada, tfujiwar
  • Readability Approval for C++ from tkng, tsawada, primenumber

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python
  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

@iizukak
Copy link
Member

iizukak commented Jun 15, 2020

@oatawa1
Thanks. The year is how to define?
File create date?

@oatawa1
Copy link
Contributor Author

oatawa1 commented Jun 15, 2020

@iizukak I checked each individual file history in github.

@iizukak
Copy link
Member

iizukak commented Jun 15, 2020

@oatawa1 OK Thanks.

Copy link
Member

@iizukak iizukak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OA

@oatawa1
Copy link
Contributor Author

oatawa1 commented Jun 18, 2020

@iizukak Thank you.

@oatawa1
Copy link
Contributor Author

oatawa1 commented Jun 18, 2020

Because this PR committed python and C++ file.
I may request review from two persons at a time.

@a-hanamoto Could you review the python file in this PR?
@primenumber Could you review the C++ file in this PR?

Copy link
Contributor

@primenumber primenumber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RA for C++

@oatawa1
Copy link
Contributor Author

oatawa1 commented Jun 18, 2020

@primenumber Thank you.

Copy link

@a-hanamoto a-hanamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RA (reverse-shadowing) for Python

@a-hanamoto a-hanamoto requested a review from tfujiwar June 18, 2020 10:03
Copy link
Contributor

@tfujiwar tfujiwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RA

@oatawa1
Copy link
Contributor Author

oatawa1 commented Jun 19, 2020

@a-hanamoto @tfujiwar Thank you.

@oatawa1
Copy link
Contributor Author

oatawa1 commented Jun 19, 2020

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Jun 19, 2020

⏳Merge job is queued...

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ oatawa1
❌ bo-mergebot[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

@bo-mergebot bo-mergebot bot merged commit 107c4fc into blue-oil:master Jun 19, 2020
@oatawa1 oatawa1 deleted the add-header-license branch June 23, 2020 02:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI: auto-run Run CI automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants