-
Notifications
You must be signed in to change notification settings - Fork 86
Conversation
This PR needs Approvals as follows.
Please choose reviewers and requet reviews! Click to see how to approve each reviewsYou can approve this PR by triggered comments as follows.
See all trigger commentsPlease replace [Target] to review target
|
@oatawa1 |
@iizukak I checked each individual file history in github. |
@oatawa1 OK Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OA
@iizukak Thank you. |
Because this PR committed python and C++ file. @a-hanamoto Could you review the python file in this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RA for C++
@primenumber Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RA (reverse-shadowing) for Python
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RA
@a-hanamoto @tfujiwar Thank you. |
/ready |
⏳Merge job is queued... |
|
What this patch does to fix the issue.
Target files are
*.py
,*.cpp
,*.h
,*.hpp
=
in the last line of license to 77. There are 78 for some of C++ src and header files.Link to any relevant issues or pull requests.