Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Report maximum diff #1109

Merged
merged 2 commits into from
Jun 22, 2020
Merged

Report maximum diff #1109

merged 2 commits into from
Jun 22, 2020

Conversation

primenumber
Copy link
Contributor

@primenumber primenumber commented Jun 22, 2020 •
edited by tfujiwar
Loading

No description provided.

@primenumber primenumber added the enhancement New feature or request label Jun 22, 2020
@primenumber primenumber self-assigned this Jun 22, 2020
@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Jun 22, 2020
@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Ownership Approval for / from iizukak, tkng, ruimashita

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python

  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

@primenumber primenumber requested a review from tkng June 22, 2020 03:59
@tkng
Copy link
Contributor

tkng commented Jun 22, 2020

OA
RA

@primenumber
Copy link
Contributor Author

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Jun 22, 2020

⏳Merge job is queued...

@tkng
Copy link
Contributor

tkng commented Jun 22, 2020

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Jun 22, 2020

⏳Merge job is queued...

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ primenumber
❌ bo-mergebot[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

@tkng
Copy link
Contributor

tkng commented Jun 22, 2020

sorry, duplicated

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Jun 22, 2020

😥Not mergeable. Please fix problems and send /ready again.

1 similar comment
@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Jun 22, 2020

😥Not mergeable. Please fix problems and send /ready again.

@tfujiwar
Copy link
Contributor

@tkng Could you approve the PR? At least 1 approval is required in addition to OA and RA comments.

@tkng
Copy link
Contributor

tkng commented Jun 22, 2020

@tfujiwar oops, I've forgotten the behavior of github. approved.

@tkng
Copy link
Contributor

tkng commented Jun 22, 2020

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Jun 22, 2020

⏳Merge job is queued...

@bo-mergebot bo-mergebot bot merged commit 0d22ed4 into blue-oil:master Jun 22, 2020
@primenumber primenumber deleted the report-max-diff branch June 22, 2020 05:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tkng tkng tkng approved these changes

Assignees

@primenumber primenumber

Labels
CI: auto-run Run CI automatically enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@primenumber @tkng @CLAassistant @tfujiwar