Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Rename depth to channels #1118

Merged
merged 8 commits into from
Jul 9, 2020

Conversation

primenumber
Copy link
Contributor

What this patch does to fix the issue.

there are several naming for 'number of channels in a layer: depth channel channels
This PR unify to channels.
kernel_depth (for convolution) -> input_channels
depths -> channels_list
channel -> channels
depth -> channels

Link to any relevant issues or pull requests.

@primenumber primenumber requested review from iizukak and a-hanamoto July 8, 2020 06:23
@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Jul 8, 2020
@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Ownership Approval for / from iizukak, tkng, ruimashita
  • Readability Approval for Python from tkng, tsawada, tfujiwar

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python
  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

Copy link

@a-hanamoto a-hanamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RA (reverse-shadowing)

@a-hanamoto
Copy link

Please assign a readability reviewer after getting OA.

@primenumber primenumber self-assigned this Jul 8, 2020
Copy link
Member

@iizukak iizukak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OA

@iizukak
Copy link
Member

iizukak commented Jul 9, 2020

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Jul 9, 2020

⏳Merge job is queued...

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Jul 9, 2020

😥This PR is not approved yet.

@tkng
Copy link
Contributor

tkng commented Jul 9, 2020

RA

@tkng
Copy link
Contributor

tkng commented Jul 9, 2020

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Jul 9, 2020

⏳Merge job is queued...

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ primenumber
❌ bo-mergebot[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

@iizukak
Copy link
Member

iizukak commented Jul 9, 2020

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Jul 9, 2020

⏳Merge job is queued...

@bo-mergebot bo-mergebot bot merged commit a1c8f87 into blue-oil:master Jul 9, 2020
@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Jul 9, 2020

😥Not mergeable. Please fix problems and send /ready again.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI: auto-run Run CI automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants