-
Notifications
You must be signed in to change notification settings - Fork 86
Conversation
This PR needs Approvals as follows.
Please choose reviewers and requet reviews! Click to see how to approve each reviewsYou can approve this PR by triggered comments as follows.
See all trigger commentsPlease replace [Target] to review target
|
I manually tested both |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RA (reverse-shadowing)
with a comment.
Co-authored-by: Atsushi Hanamoto <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RA
Thank you!!
/ready |
⏳Merge job is queued... |
|
OA |
What this patch does to fix the issue.
Fix #1121
If
path
is started withgs://
, then we do not add convert to local absolute path.