Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

FIx to set correct gs:// path #1122

Merged
merged 4 commits into from
Jul 20, 2020

Conversation

iizukak
Copy link
Member

@iizukak iizukak commented Jul 17, 2020

What this patch does to fix the issue.

Fix #1121

If path is started with gs://, then we do not add convert to local absolute path.

@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Jul 17, 2020
@iizukak iizukak requested a review from yshrkume July 17, 2020 05:36
@iizukak iizukak changed the title [WIP] FIx to set correct gs:// path FIx to set correct gs:// path Jul 20, 2020
@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Readability Approval for Python from tkng, tsawada, tfujiwar

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python
  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

@iizukak
Copy link
Member Author

iizukak commented Jul 20, 2020

I manually tested both DATA_DIR and OUTPUT_DIR are GCS path case.

@iizukak iizukak requested a review from a-hanamoto July 20, 2020 00:45
Copy link

@yshrkume yshrkume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@a-hanamoto a-hanamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RA (reverse-shadowing)
with a comment.

Co-authored-by: Atsushi Hanamoto <[email protected]>
@iizukak iizukak requested a review from tfujiwar July 20, 2020 01:50
Copy link
Contributor

@tfujiwar tfujiwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RA
Thank you!!

@iizukak
Copy link
Member Author

iizukak commented Jul 20, 2020

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Jul 20, 2020

⏳Merge job is queued...

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ iizukak
❌ bo-mergebot[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

@iizukak
Copy link
Member Author

iizukak commented Jul 20, 2020

OA

@tfujiwar tfujiwar changed the title FIx to set correct gs:// path [WIP] FIx to set correct gs:// path Jul 20, 2020
@tfujiwar tfujiwar changed the title [WIP] FIx to set correct gs:// path FIx to set correct gs:// path Jul 20, 2020
@bo-mergebot bo-mergebot bot merged commit 852133f into blue-oil:master Jul 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI: auto-run Run CI automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OUTPUT_DIR with the gcs path does not work
5 participants