Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Remove hw directory and replace it in GCS #1131

Merged
merged 2 commits into from
Jul 29, 2020

Conversation

kchygoe
Copy link
Member

@kchygoe kchygoe commented Jul 23, 2020

  • Remove hw/intel/de10_nano directory
  • Place sample OS image/config files on a bucket, gs://blueoil-asia-northeast1
  • Fix document to download them from the bucket

What this patch does to fix the issue.

HW directory includes binaries and makes repo size big.
These files should be place in a bucket.

Link to any relevant issues or pull requests.

#619

@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Jul 23, 2020
@kchygoe kchygoe requested review from iizukak and hadusam July 29, 2020 03:02
Copy link
Member

@iizukak iizukak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OA
Nice PR~

Copy link
Contributor

@hadusam hadusam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:+1:

@hadusam hadusam changed the title Remove hw directory and replace it in GCS [WIP] Remove hw directory and replace it in GCS Jul 29, 2020
@hadusam hadusam changed the title [WIP] Remove hw directory and replace it in GCS Remove hw directory and replace it in GCS Jul 29, 2020
@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Ownership Approval for / from iizukak, tkng, ruimashita

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python
  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

@kchygoe
Copy link
Member Author

kchygoe commented Jul 29, 2020

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Jul 29, 2020

⏳Merge job is queued...

@bo-mergebot bo-mergebot bot merged commit de05760 into blue-oil:master Jul 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI: auto-run Run CI automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants