Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Add blank line between copyright header and code #1133

Merged
merged 1 commit into from
Jul 28, 2020
Merged

Add blank line between copyright header and code #1133

merged 1 commit into from
Jul 28, 2020

Conversation

oatawa1
Copy link
Contributor

@oatawa1 oatawa1 commented Jul 27, 2020 •
edited by tfujiwar
Loading

What this patch does to fix the issue.
Add blank line between copyright header and code in file with more comments or # NOQA

@oatawa1 oatawa1 requested a review from iizukak July 27, 2020 07:46
@oatawa1 oatawa1 self-assigned this Jul 27, 2020
@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Jul 27, 2020
@oatawa1 oatawa1 changed the title Add blank line between copyright header and code in file with more co… Add blank line between copyright header and code Jul 27, 2020
iizukak
iizukak approved these changes Jul 28, 2020
View reviewed changes
Copy link
Member

@iizukak iizukak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OA

@oatawa1
Copy link
Contributor Author

oatawa1 commented Jul 28, 2020

@iizukak Thanks.

@oatawa1 oatawa1 requested a review from tfujiwar July 28, 2020 06:35
tfujiwar
tfujiwar approved these changes Jul 28, 2020
View reviewed changes
Copy link
Contributor

@tfujiwar tfujiwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RA

@tfujiwar tfujiwar changed the title Add blank line between copyright header and code [WIP] Add blank line between copyright header and code Jul 28, 2020
@tfujiwar tfujiwar changed the title [WIP] Add blank line between copyright header and code Add blank line between copyright header and code Jul 28, 2020
@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Ownership Approval for / from iizukak, tkng, ruimashita
  • Readability Approval for Python from tkng, tsawada, tfujiwar

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python

  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

@oatawa1
Copy link
Contributor Author

oatawa1 commented Jul 28, 2020

@tfujiwar Thank you.

@oatawa1
Copy link
Contributor Author

oatawa1 commented Jul 28, 2020

/ready

@oatawa1 oatawa1 changed the title Add blank line between copyright header and code [WIP] Add blank line between copyright header and code Jul 28, 2020
@oatawa1 oatawa1 changed the title [WIP] Add blank line between copyright header and code Add blank line between copyright header and code Jul 28, 2020
@oatawa1 oatawa1 merged commit 3448f0d into blue-oil:master Jul 28, 2020
@oatawa1 oatawa1 deleted the quickfix-add-blank-link branch July 28, 2020 07:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iizukak iizukak iizukak approved these changes

@tfujiwar tfujiwar tfujiwar approved these changes

Assignees

@oatawa1 oatawa1

Labels
CI: auto-run Run CI automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oatawa1 @iizukak @tfujiwar