Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Fix comments typo in base.py #1135

Merged
merged 2 commits into from
Aug 3, 2020
Merged

Fix comments typo in base.py #1135

merged 2 commits into from
Aug 3, 2020

Conversation

oatawa1
Copy link
Contributor

@oatawa1 oatawa1 commented Jul 29, 2020

What this patch does to fix the issue.

Fix comments typo in base.py

Link to any relevant issues or pull requests.

@oatawa1 oatawa1 requested a review from iizukak July 29, 2020 08:01
@oatawa1 oatawa1 self-assigned this Jul 29, 2020
@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Jul 29, 2020
iizukak
iizukak approved these changes Aug 3, 2020
View reviewed changes
Copy link
Member

@iizukak iizukak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OA

@iizukak iizukak requested a review from tsawada August 3, 2020 02:21
tsawada
tsawada approved these changes Aug 3, 2020
View reviewed changes
Copy link
Contributor

@tsawada tsawada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readability Approval

@oatawa1
Copy link
Contributor Author

oatawa1 commented Aug 3, 2020

@iizukak @tsawada Thank you for your review.

@oatawa1
Copy link
Contributor Author

oatawa1 commented Aug 3, 2020

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Aug 3, 2020

⏳Merge job is queued...

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Aug 3, 2020

😥This PR is not approved yet.

@kchygoe kchygoe changed the title Fix comments typo in base.py [WIP] Fix comments typo in base.py Aug 3, 2020
@kchygoe kchygoe changed the title [WIP] Fix comments typo in base.py Fix comments typo in base.py Aug 3, 2020
@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Ownership Approval for / from iizukak, tkng, ruimashita
  • Readability Approval for Python from tkng, tsawada, tfujiwar

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python

  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

@kchygoe
Copy link
Member

kchygoe commented Aug 3, 2020

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Aug 3, 2020

⏳Merge job is queued...

@bo-mergebot bo-mergebot bot merged commit 637edca into blue-oil:master Aug 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iizukak iizukak iizukak approved these changes

@tsawada tsawada tsawada approved these changes

Assignees

@oatawa1 oatawa1

Labels
CI: auto-run Run CI automatically documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oatawa1 @kchygoe @iizukak @tsawada