Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

capitalize help messages #1137

Merged
merged 2 commits into from
Jul 30, 2020
Merged

Conversation

joelN123
Copy link
Contributor

What this patch does to fix the issue.

There are a couple of lines in main.py where the help messages don't have capitalization at the start of the sentence. Correct that in this PR.

@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Jul 29, 2020
@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Ownership Approval for / from iizukak, tkng, ruimashita
  • Readability Approval for Python from tkng, tsawada, tfujiwar

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python
  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

@joelN123 joelN123 requested a review from iizukak July 29, 2020 09:57
Copy link
Member

@iizukak iizukak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OA
Thank your for fixing.

@iizukak iizukak requested a review from tfujiwar July 30, 2020 00:58
Copy link
Contributor

@tfujiwar tfujiwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RA

@joelN123
Copy link
Contributor Author

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Jul 30, 2020

⏳Merge job is queued...

@bo-mergebot bo-mergebot bot merged commit 43bd2e1 into blue-oil:master Jul 30, 2020
@joelN123 joelN123 deleted the fix-capitalization branch July 30, 2020 04:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI: auto-run Run CI automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants