Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Upgrade OS version to bionic for Docker image #1139

Merged
merged 7 commits into from
Jul 31, 2020
Merged

Upgrade OS version to bionic for Docker image #1139

merged 7 commits into from
Jul 31, 2020

Conversation

kchygoe
Copy link
Member

@kchygoe kchygoe commented Jul 29, 2020 •
edited
Loading

What this patch does to fix the issue.

  • Upgrade Base OS version from xenial to bionic(Ubuntu 18.04)
  • Drop python2 support from device side
  • Add uninstallation of enum34 task in CI because this package makes other packages unavailable to be installed
  • font package is required because bionic image doesn't provide it by default

Link to any relevant issues or pull requests.

Related to #1138

@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Jul 29, 2020
@kchygoe
Copy link
Member Author

kchygoe commented Jul 29, 2020

@iizukak Sorry, could you tell me why g++-9 is now installed in Docker image?
#690

iizukak
iizukak approved these changes Jul 30, 2020
View reviewed changes
Copy link
Member

@iizukak iizukak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OA
Super!

@kchygoe
Copy link
Member Author

kchygoe commented Jul 30, 2020

need to uninstall enum34 on device to install newer pip packages

@kchygoe kchygoe changed the title [WIP] Upgrade OS version to bionic for Docker image Upgrade OS version to bionic for Docker image Jul 30, 2020
@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Ownership Approval for / from iizukak, tkng, ruimashita

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python

  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

@kchygoe kchygoe requested a review from hadusam July 30, 2020 09:37
hadusam
hadusam reviewed Jul 31, 2020
View reviewed changes
Copy link
Contributor

@hadusam hadusam left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for supper nice PR 😆

IMO: I think this PR is complex. How about separating this PR as following,

  • Upgrade OS version to bionic for Docker image
    with

    • Drop python2 support from device side
    • font package is required because bionic image doesn't provide it by default

  • Update device side requirements.txt
    with

    • Add uninstallation of enum34 task in CI because this package makes other packages unavailable to be installed

I am not sure that we can separate this, but these two updates are big changes so it is better to treat them as different commits and reviews.
What do you think? @kchygoe

@kchygoe
Copy link
Member Author

kchygoe commented Jul 31, 2020 •
edited
Loading

Good point!
ya, I'm thinking about that

@kchygoe
Copy link
Member Author

kchygoe commented Jul 31, 2020

  • Regarding gcc version, I will create another PR.
  • requirements.txt will be updated in another PR, too

hadusam
hadusam approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@hadusam hadusam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! w/ a comment.
Thank you so much 😄

.buildkite/blueoil-pipeline.yml
@@ -68,12 +68,15 @@ steps:
python3 -m venv blueoil_inference
source blueoil_inference/bin/activate
pip3 install -U pip
pip3 uninstall -y enum34
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure why we need this line.
Do we need this line at this time?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this uninstall operation is temporary for miss much of requirements.txt between each CI of existing PRs, I think it is better to add a comment or create an issue to remove this line 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx, I will make an issue

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1143

@kchygoe
Copy link
Member Author

kchygoe commented Jul 31, 2020

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Jul 31, 2020

⏳Merge job is queued...

@kchygoe kchygoe mentioned this pull request Jul 31, 2020
Open
@bo-mergebot bo-mergebot bot merged commit d9aa554 into blue-oil:master Jul 31, 2020
@kchygoe kchygoe mentioned this pull request Jul 31, 2020
Merged
bo-mergebot bot pushed a commit that referenced this pull request Aug 3, 2020
@kchygoe
Update Raspberry-Pi CI env (#1147)
60fd324 
## What this patch does to fix the issue.
This change enables CI test on multiple raspberry-pi3 devices in parallel


## Link to any relevant issues or pull requests.
Related to #1139
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iizukak iizukak iizukak approved these changes

@hadusam hadusam hadusam approved these changes

Assignees
No one assigned
Labels
CI: auto-run Run CI automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kchygoe @iizukak @hadusam