Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Lookup without DivideBy255 #1161

Merged
merged 14 commits into from
Aug 28, 2020

Conversation

primenumber
Copy link
Contributor

@primenumber primenumber commented Aug 14, 2020

What this patch does to fix the issue.

Lookup operator supports inputs without normalized to 0〜1:

  • blueoil convert command check network config whether DivideBy255 pre-processor exists or not
  • func_Lookup takes new parameter use_divide_by_255
  • generate_project.py has new option -div / -no-div to set use_divide_by_255
  • set use_divide_by_255 from whether DivideBy255 pre-processor exists or not

Link to any relevant issues or pull requests.

Fix #1157 .

@primenumber primenumber added the enhancement New feature or request label Aug 14, 2020
@primenumber primenumber self-assigned this Aug 14, 2020
@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Aug 14, 2020
@primenumber primenumber changed the title [WIP] Lookup without div255 [WIP] Lookup without DivideBy255 Aug 14, 2020
@primenumber primenumber changed the title [WIP] Lookup without DivideBy255 Lookup without DivideBy255 Aug 19, 2020
@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Ownership Approval for / from iizukak, tkng, ruimashita
  • Readability Approval for Python from tkng, tsawada, tfujiwar

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python
  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

@primenumber primenumber requested a review from tkng August 19, 2020 07:12
Copy link
Member

@iizukak iizukak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OA

@iizukak
Copy link
Member

iizukak commented Aug 28, 2020

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Aug 28, 2020

⏳Merge job is queued...

@iizukak
Copy link
Member

iizukak commented Aug 28, 2020

wow, sorry python readability review is not yet

@iizukak iizukak requested a review from tfujiwar August 28, 2020 04:38
Copy link
Contributor

@tfujiwar tfujiwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RA

@bo-mergebot bo-mergebot bot merged commit 3510e3f into blue-oil:master Aug 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI: auto-run Run CI automatically enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lookup without DivideBy255 pre-processor
3 participants