Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Fix an error of runtime with no bounding box of object detection #1163

Merged
merged 2 commits into from
Aug 28, 2020

Conversation

tk26eng
Copy link
Contributor

@tk26eng tk26eng commented Aug 14, 2020

What this patch does to fix the issue.

This PR fix the error of runtime.
The problem occurs when no bounding box is detected with object detection task.
Then some values divided by zero, so the exception happens.

Link to any relevant issues or pull requests.

Fix #1162

@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Aug 14, 2020
@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Ownership Approval for / from iizukak, tkng, ruimashita
  • Readability Approval for C++ from tkng, tsawada, primenumber

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python
  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

@tk26eng tk26eng self-assigned this Aug 14, 2020
@tk26eng tk26eng requested a review from iizukak August 14, 2020 15:29
Copy link
Member

@iizukak iizukak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OA

@tk26eng tk26eng requested a review from primenumber August 17, 2020 04:10
@tk26eng
Copy link
Contributor Author

tk26eng commented Aug 17, 2020

@primenumber

Could you please review this PR ?

Copy link
Contributor

@primenumber primenumber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RA for C++

@tk26eng
Copy link
Contributor Author

tk26eng commented Aug 28, 2020

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Aug 28, 2020

⏳Merge job is queued...

@bo-mergebot bo-mergebot bot merged commit 7497f34 into blue-oil:master Aug 28, 2020
@tk26eng tk26eng deleted the check_empty_tensor branch August 28, 2020 02:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI: auto-run Run CI automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An error happens with no detected bounding box on object detection
3 participants