Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Fix absl-py version to 0.8.1 #1168

Merged
merged 1 commit into from
Aug 18, 2020

Conversation

oatawa1
Copy link
Contributor

@oatawa1 oatawa1 commented Aug 18, 2020

What this patch does to fix the issue.

This PR fix absl-py version to 0.8.1 (the latest version before 0.9)
Because absl-py require <0.9, >=0.7

Note that Blueoil code didn't require absl-py but it required by TensorFlow.

Link to any relevant issues or pull requests.

#1167

@oatawa1 oatawa1 added bug Something isn't working dependencies Pull requests that update a dependency file labels Aug 18, 2020
@oatawa1 oatawa1 requested a review from iizukak August 18, 2020 03:40
@oatawa1 oatawa1 self-assigned this Aug 18, 2020
@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Aug 18, 2020
@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Ownership Approval for / from iizukak, tkng, ruimashita

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python
  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

@iizukak
Copy link
Member

iizukak commented Aug 18, 2020

@oatawa1
There is no problem if we use 0.8.1?
I think some library required 0.9 in dependency and this issue happen.

@oatawa1
Copy link
Contributor Author

oatawa1 commented Aug 18, 2020

@iizukak I thought the 0.8.1 could work so.

I checked it using pip check
First check which dependency need absl-py

# pip check
tensorflow-metadata 0.23.0 requires absl-py, which is not installed.
tensorflow-gpu 1.15.3 requires absl-py, which is not installed.
tensorflow-datasets 1.3.0 requires absl-py, which is not installed.
tensorboard 1.15.0 requires absl-py, which is not installed.

After I installed the absl-py.

absl-py==0.9.0

# pip check
tensorflow-metadata 0.23.0 has requirement absl-py<0.9,>=0.7, but you have absl-py 0.9.0.

absl-py==0.8.1

# pip check
No broken requirements found.

@iizukak
Copy link
Member

iizukak commented Aug 18, 2020

@oatawa1 Great.

Copy link
Member

@iizukak iizukak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OA

@iizukak
Copy link
Member

iizukak commented Aug 18, 2020

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Aug 18, 2020

⏳Merge job is queued...

@bo-mergebot bo-mergebot bot merged commit 8fe8d62 into blue-oil:master Aug 18, 2020
@oatawa1
Copy link
Contributor Author

oatawa1 commented Aug 18, 2020

In our case, the tensorflow-datasets==1.3.0 required absl-py but it did not specify the version so it installed the latest version.
Then the tensorflow-meradata is installed with tensorflow which required < 0.9, so it got error.

@oatawa1 oatawa1 deleted the fix-absl-py-version branch August 21, 2020 03:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working CI: auto-run Run CI automatically dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants