Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Use g++-8 to keep consistency in each architecture #1190

Merged
merged 1 commit into from
Sep 2, 2020

Conversation

hadusam
Copy link
Contributor

@hadusam hadusam commented Aug 28, 2020

What this patch does to fix the issue.

Close #1189

% docker run --rm -it blueoil_masuda:v0.27.0-18-g4db3ba40 /bin/bash
root@2cc8feb8e3a2:/home/blueoil# g++ --version
g++ (Ubuntu 8.4.0-1ubuntu1~18.04) 8.4.0
Copyright (C) 2018 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

root@2cc8feb8e3a2:/home/blueoil# arm-linux-gnueabihf-g++ --version
arm-linux-gnueabihf-g++ (Ubuntu/Linaro 8.4.0-1ubuntu1~18.04) 8.4.0
Copyright (C) 2018 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

root@2cc8feb8e3a2:/home/blueoil# aarch64-linux-gnu-g++ --version
aarch64-linux-gnu-g++ (Ubuntu/Linaro 8.4.0-1ubuntu1~18.04) 8.4.0
Copyright (C) 2018 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Link to any relevant issues or pull requests.

@hadusam hadusam self-assigned this Aug 28, 2020
@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Aug 28, 2020
@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Ownership Approval for / from iizukak, tkng, ruimashita

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python
  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

@hadusam hadusam requested review from iizukak and kchygoe August 31, 2020 02:23
Copy link
Member

@iizukak iizukak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OA
Sorry for review delaying

@iizukak
Copy link
Member

iizukak commented Sep 2, 2020

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Sep 2, 2020

⏳Merge job is queued...

@bo-mergebot bo-mergebot bot merged commit d477924 into blue-oil:master Sep 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI: auto-run Run CI automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

g++ versions are not same in each architecture
2 participants