This repository has been archived by the owner on Dec 1, 2021. It is now read-only.
Fix MAX_STEPS = 0 error by add suggestion and exit #1195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR needs Approvals as follows.
Please choose reviewers and requet reviews! Click to see how to approve each reviewsYou can approve this PR by triggered comments as follows.
See all trigger commentsPlease replace [Target] to review target
|
|
@iizukak Thank you. |
oatawa1
changed the title
oatawa1
force-pushed
the
fix-max-steps-0
branch
from
bae1274 to
b66c326
Compare
tfujiwar
approved these changes
Sep 3, 2020
blueoil/cmd/train.py
Outdated
| @@ -192,8 +193,14 @@ def start_training(config, profile_step): | |||
| # Calculate max steps. The priority of config.MAX_EPOCHS is higher than config.MAX_STEPS. | |||
| if "MAX_EPOCHS" in config: | |||
| max_steps = int(train_dataset.num_per_epoch / config.BATCH_SIZE * config.MAX_EPOCHS) | |||
| if max_steps < 1: | |||
| print("The max_steps is less than 1, consider reduce BATCH_SIZE. exit.") | |||
There was a problem hiding this comment.
Suggested change
| print("The max_steps is less than 1, consider reduce BATCH_SIZE. exit.") | |
| print("The max_steps is less than 1, consider reduce BATCH_SIZE. exit.", file=sys.stderr) |
blueoil/cmd/train.py
Outdated
| else: | ||
| max_steps = config.MAX_STEPS | ||
| if max_steps < 1: | ||
| print("The max_steps is less than 1, consider set MAX_STEPS greater than 0. exit.") |
There was a problem hiding this comment.
Suggested change
| print("The max_steps is less than 1, consider set MAX_STEPS greater than 0. exit.") | |
| print("The max_steps is less than 1, consider set MAX_STEPS greater than 0. exit.", file=sys.stderr) |
|
@tfujiwar Thank you. I fixed your suggestion. I will merge this after it passed CI. |
|
/ready |
|
⏳Merge job is queued... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this patch does to fix the issue.
Change the minimum no. of
MAX_STEPSto 1.Link to any relevant issues or pull requests.
#1194