Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Remove output_event.py #1219

Merged
merged 2 commits into from
Sep 28, 2020
Merged

Remove output_event.py #1219

merged 2 commits into from
Sep 28, 2020

Conversation

iizukak
Copy link
Member

@iizukak iizukak commented Sep 28, 2020

Solve #1218

@iizukak iizukak requested a review from oatawa1 September 28, 2020 00:46
@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Sep 28, 2020
@oatawa1 oatawa1 changed the title Remove outpute_event.py Remove output_event.py Sep 28, 2020
@oatawa1
Copy link
Contributor

oatawa1 commented Sep 28, 2020

@iizukak Could you resolve the CI failed?

How about removing the output_event unit test?
https://github.com/blue-oil/blueoil/blob/master/tests/unit/executor_tests/test_output_event.py

@iizukak
Copy link
Member Author

iizukak commented Sep 28, 2020

@oatawa1 Thanks. Removed.

oatawa1
oatawa1 approved these changes Sep 28, 2020
View reviewed changes
Copy link
Contributor

@oatawa1 oatawa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@iizukak
Copy link
Member Author

iizukak commented Sep 28, 2020

@oatawa1
Thanks.

@iizukak
Copy link
Member Author

iizukak commented Sep 28, 2020

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Sep 28, 2020

⏳Merge job is queued...

@bo-mergebot bo-mergebot bot merged commit a6a622d into blue-oil:master Sep 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@oatawa1 oatawa1 oatawa1 approved these changes

Assignees
No one assigned
Labels
CI: auto-run Run CI automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iizukak @oatawa1