This repository has been archived by the owner on Dec 1, 2021. It is now read-only.
Delete absolute mode path from train executor #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yasumura-lm
changed the title
iizukak
approved these changes
Sep 18, 2019
tsawada
reviewed
Sep 18, 2019
| @@ -26,6 +26,7 @@ | |||
| from lmnet.datasets.base import ObjectDetectionBase | |||
| from lmnet.datasets.dataset_iterator import DatasetIterator | |||
| from lmnet.datasets.tfds import TFDSClassification, TFDSObjectDetection | |||
| from lmnet.common import Tasks | |||
There was a problem hiding this comment.
Please sort imports. Other files as well.
|
Please do not ignore readability review comments :( |
|
Oops, sorry, I missed. |
ananno
pushed a commit
to ananno/blueoil
that referenced
this pull request
Sep 27, 2019
* delete absolute mode class path * add task type to test config
ananno
pushed a commit
to ananno/blueoil
that referenced
this pull request
Sep 27, 2019
* delete absolute mode class path * add task type to test config
ananno
pushed a commit
to ananno/blueoil
that referenced
this pull request
Sep 30, 2019
* delete absolute mode class path * add task type to test config
ananno
pushed a commit
to ananno/blueoil
that referenced
this pull request
Oct 3, 2019
* delete absolute mode class path * add task type to test config
ananno
pushed a commit
to ananno/blueoil
that referenced
this pull request
Oct 3, 2019
* delete absolute mode class path * add task type to test config
ananno
pushed a commit
to ananno/blueoil
that referenced
this pull request
Oct 10, 2019
* delete absolute mode class path * add task type to test config
ananno
pushed a commit
to ananno/blueoil
that referenced
this pull request
Oct 28, 2019
* delete absolute mode class path * add task type to test config
ananno
pushed a commit
to ananno/blueoil
that referenced
this pull request
Oct 29, 2019
* delete absolute mode class path * add task type to test config
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
If you create some new object detection class outside of
lmnet.networks.object_detection, train executor doesn't work.Description
Changed to use task type (
Tasks.OBJECT_DETECTION) from class pathHow has this been tested?
only unit test
Screenshots (if appropriate):
Types of changes
Checklist: