Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Remove py35 target on test-lmnet #450

Merged
merged 2 commits into from
Sep 20, 2019
Merged

Remove py35 target on test-lmnet #450

merged 2 commits into from
Sep 20, 2019

Conversation

suttang
Copy link
Contributor

@suttang suttang commented Sep 20, 2019

Motivation and Context

We have ended support for Python 3.5.
This PR fixes #410

Description

How has this been tested?

$ make test-lmnet
$ cd lmnet && tox

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature / Optimization (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Sep 20, 2019
@suttang suttang marked this pull request as ready for review September 20, 2019 10:53
@suttang suttang changed the title [WIP] Remove py35 target on test-lmnet Remove py35 target on test-lmnet Sep 20, 2019
@tkng
Copy link
Contributor

tkng commented Sep 20, 2019 •
edited
Loading

  • ownership approval
  • readability approval

@tkng tkng self-requested a review September 20, 2019 14:49
@tkng tkng merged commit d68b8c0 into blue-oil:master Sep 20, 2019
ananno pushed a commit to ananno/blueoil that referenced this pull request Sep 27, 2019
@suttang @ananno
remove py35 target on test-lmnet (blue-oil#450)
d809ef2
@iizukak iizukak added this to the v0.12.0 milestone Oct 3, 2019
@suttang suttang deleted the remove-py35-test branch October 7, 2019 08:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tkng tkng tkng approved these changes

Assignees
No one assigned
Labels
CI: auto-run Run CI automatically
Projects
None yet
Milestone
v0.12.0
Development

Successfully merging this pull request may close these issues.

Remove Python 3.5 support
3 participants
@suttang @tkng @iizukak