Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Raise TypeError in view.run() if op_type is not supported #540

Merged
merged 8 commits into from
Nov 1, 2019

Conversation

yd8534976
Copy link
Contributor

@yd8534976 yd8534976 commented Oct 18, 2019

Raise TypeError in view.run() if op_type is not supported.

When we add a new op into dlk, we have to add related codes in view.py to generate code.
This PR will inform us if we miss this piece of code.

Motivation and Context

Description

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature / Optimization (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Oct 18, 2019
@yd8534976 yd8534976 changed the title [WIP] Raise TypeError in view.run() if op_type is not supported Raise TypeError in view.run() if op_type is not supported Oct 18, 2019
@yd8534976 yd8534976 force-pushed the raise_error_in_view branch from 7139bf3 to 831493f Compare October 21, 2019 02:11
@iizukak iizukak requested a review from tkng October 25, 2019 01:04
Copy link
Member

@iizukak iizukak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ownership Approval.

Copy link
Contributor

@tkng tkng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • readability approval

@yd8534976 yd8534976 merged commit 0130eeb into blue-oil:master Nov 1, 2019
@yd8534976 yd8534976 deleted the raise_error_in_view branch November 1, 2019 09:24
@iizukak iizukak added this to the v0.14.0 milestone Nov 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI: auto-run Run CI automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants