Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Add buf parameter of matrix layout convertion functions #571

Merged
merged 4 commits into from
Oct 31, 2019

Conversation

primenumber
Copy link
Contributor

This PR adds new parameter to row_major_to_col_major and col_major_to_row_major.
New parameter is buffer pointer to store elements of new matrix.
Caller of the function have to manage the buffer, we can use std::unique_ptr<T>.

Motivation and Context

row_major_to_col_major and col_major_to_row_major allocate new buffer in function, this behavior may cause memory leak and difficult to optimize memory use.

Description

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature / Optimization (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@primenumber primenumber self-assigned this Oct 29, 2019
@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Oct 29, 2019
@primenumber
Copy link
Contributor Author

run lmnet test

@blueoil-butler blueoil-butler bot added CI: test-lmnet Run lmnet test once and removed CI: test-lmnet Run lmnet test once labels Oct 29, 2019
@primenumber
Copy link
Contributor Author

run dlk test

@blueoil-butler blueoil-butler bot added CI: test-dlk Run dlk test once and removed CI: test-dlk Run dlk test once labels Oct 30, 2019
@iizukak iizukak requested a review from tkng October 31, 2019 00:44
Copy link
Contributor

@tkng tkng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

@tkng tkng merged commit e9c9b80 into blue-oil:master Oct 31, 2019
@primenumber primenumber deleted the feature/matrix-layout branch November 1, 2019 02:11
@iizukak iizukak added this to the v0.14.0 milestone Nov 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI: auto-run Run CI automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants