This repository has been archived by the owner on Dec 1, 2021. It is now read-only.
Add buf parameter of matrix layout convertion functions #571
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new parameter to row_major_to_col_major and col_major_to_row_major.
New parameter is buffer pointer to store elements of new matrix.
Caller of the function have to manage the buffer, we can use
std::unique_ptr<T>
.Motivation and Context
row_major_to_col_major and col_major_to_row_major allocate new buffer in function, this behavior may cause memory leak and difficult to optimize memory use.
Description
How has this been tested?
Screenshots (if appropriate):
Types of changes
Checklist: