This repository has been archived by the owner on Dec 1, 2021. It is now read-only.
Refactor predict output #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iizukak
reviewed
Oct 31, 2019
| numpy array, JSON, and images if you want. | ||
|
|
||
| Args: | ||
| dest (str): paht to save file |
| save_materials(dest, materials, step) | ||
|
|
||
|
|
||
| def save_npy(dest, outputs, step): |
There was a problem hiding this comment.
Why these function are not method of OutputWriter ?
There was a problem hiding this comment.
I prefer "Don't put in a method if you don't need it" mentality.
These functions don't need the state of OutputWriter.
IMO, This makes these functions independent and easier to test.
| print("save json: {}".format(filepath)) | ||
|
|
||
|
|
||
| def save_materials(dest, materials, step): |
There was a problem hiding this comment.
save_materials looks general name. save_images is not enough?
There was a problem hiding this comment.
One day we will come to deal with tasks other than images.
Named for that time.
If not, I will fix.
tsawada
approved these changes
Oct 31, 2019
| with open(filepath, "w") as f: | ||
| f.write(json) | ||
|
|
||
| print("save json: {}".format(filepath)) |
There was a problem hiding this comment.
we should not print debugging information.
|
|
||
|
|
||
| @pytest.fixture | ||
| def temp_dir(): |
There was a problem hiding this comment.
with TemporaryDirectory() as t:
yield t.name
…lueoil into refactor/predict-output-writer
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR related to #480
To refactor the code around predict result output, we need to create
OutputWriterandOutputParserI think.In this PR, I created OutputWriter class.
Description
How has this been tested?
make testScreenshots (if appropriate):
Types of changes
Checklist: