Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Implement preserve_quantization for Prod, Shape #585

Merged
merged 3 commits into from
Nov 6, 2019
Merged

Implement preserve_quantization for Prod, Shape #585

merged 3 commits into from
Nov 6, 2019

Conversation

primenumber
Copy link
Contributor

Implement missing methods.

Motivation and Context

Description

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature / Optimization (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@primenumber primenumber self-assigned this Nov 1, 2019
@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Nov 1, 2019
@tkng tkng self-requested a review November 6, 2019 06:31
tkng
tkng approved these changes Nov 6, 2019
View reviewed changes
Copy link
Contributor

@tkng tkng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

@tkng tkng merged commit 3fc142b into blue-oil:master Nov 6, 2019
@iizukak iizukak added this to the v0.14.0 milestone Nov 7, 2019
@primenumber primenumber deleted the fix/preserve-qtz branch November 8, 2019 09:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tkng tkng tkng approved these changes

Assignees

@primenumber primenumber

Labels
CI: auto-run Run CI automatically
Projects
None yet
Milestone
v0.14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@primenumber @tkng @iizukak