Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Add CODEOWNERS file #647

Merged
merged 2 commits into from
Dec 6, 2019
Merged

Add CODEOWNERS file #647

merged 2 commits into from
Dec 6, 2019

Conversation

hadusam
Copy link
Contributor

@hadusam hadusam commented Dec 4, 2019

Add CODEOWNERS file for Bot.

@hadusam hadusam requested a review from iizukak December 4, 2019 07:15
@hadusam hadusam self-assigned this Dec 4, 2019
@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Dec 4, 2019
Copy link
Member

@iizukak iizukak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hadusam
Thanks. This is for merge bot? or reviewer assign system?

@hadusam
Copy link
Contributor Author

hadusam commented Dec 4, 2019

@iizukak
Oh, sorry for less information.
This is for reviewer assign system.

@iizukak
Copy link
Member

iizukak commented Dec 5, 2019

@hadusam
How about readablility reviewer? Add later?

@hadusam
Copy link
Contributor Author

hadusam commented Dec 5, 2019

@iizukak
Readability Reviewers are defined as Github Teams.
You can see the teams on https://github.com/orgs/blue-oil/teams

The bot will be installed on 12/6 Fri after the explanation with documents of how to approve reviews. 👍
It is necessary to merge this PR before bot installation. Sorry for fewer communications 🙇

@iizukak
Copy link
Member

iizukak commented Dec 5, 2019

@hadusam
Thank you for the information.
I understood...
Little question, why ownership reviewer is in CODEOWNERS.yaml not Github Teams?

And how about add Shell and Docker Readability reviewer ? :)

@hadusam
Copy link
Contributor Author

hadusam commented Dec 6, 2019

@iizukak

why ownership reviewer is in CODEOWNERS.yaml not Github Teams?

Good question!
At first, we need to specify owners on each directory, and we have many repositories on internal company org, so owner's lists are variable and we should support to be specified username on code owners file. Thus, currently, only supported username, but of course, I think teams for code owners will be supported in the future.

And how about add Shell and Docker Readability reviewer ? :)

That sounds great! Let's discuss it later. :)

@iizukak iizukak merged commit 3033cdf into blue-oil:master Dec 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI: auto-run Run CI automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants