Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Allocate temporary buffers in Network::init #664

Merged
merged 16 commits into from
Dec 13, 2019

Conversation

primenumber
Copy link
Contributor

This PR is premise to solve #473 .
Make easier to manage memory.

Motivation and Context

This PR allocate temporary buffers which is used operators in Network::init.
Memory allocation only occurs in Network and debug routines (such as time_measurement).

Description

  • Define unique_ptr in Network instead of global
  • Stop to use std::vector in generic qconv operator.
    • This vector is used to manage threads, so changed to use OpenMP instead native threads.

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature / Optimization (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@primenumber primenumber self-assigned this Dec 12, 2019
@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Dec 12, 2019
@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Ownership Approval for / from iizukak, tkng, ruimashita
  • Readability Approval for Python from tkng, tsawada
  • Readability Approval for C++ from tkng, tsawada

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python
  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

@primenumber primenumber requested review from iizukak and tkng December 13, 2019 02:36
@tkng
Copy link
Contributor

tkng commented Dec 13, 2019

  • Readability Approval
  • Ownership Approval

@tkng
Copy link
Contributor

tkng commented Dec 13, 2019

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Dec 13, 2019

⏳Merge job is queued...

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Dec 13, 2019

😥Status check failed. Please fix problems and send /ready again.

@tkng tkng added the CI: test-all Run all tests once label Dec 13, 2019
@blueoil-butler blueoil-butler bot removed the CI: test-all Run all tests once label Dec 13, 2019
@tkng tkng added the CI: test-all Run all tests once label Dec 13, 2019
@blueoil-butler blueoil-butler bot removed the CI: test-all Run all tests once label Dec 13, 2019
@primenumber
Copy link
Contributor Author

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Dec 13, 2019

⏳Merge job is queued...

@bo-mergebot bo-mergebot bot merged commit 2f231bb into blue-oil:master Dec 13, 2019
@primenumber primenumber deleted the allocate-in-init branch December 13, 2019 07:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI: auto-run Run CI automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants