Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Rename QTZ_linear_mid_tread_half #670

Merged
merged 3 commits into from
Mar 27, 2020
Merged

Rename QTZ_linear_mid_tread_half #670

merged 3 commits into from
Mar 27, 2020

Conversation

Joeper214
Copy link
Contributor

@Joeper214 Joeper214 commented Dec 16, 2019 •
edited
Loading

Motivation and Context

Description

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature / Optimization (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Dec 16, 2019
@Joeper214 Joeper214 self-assigned this Dec 16, 2019
@tkng tkng self-requested a review February 4, 2020 03:58
@Joeper214 Joeper214 added the CI: test-dlk Run dlk test once label Feb 4, 2020
@blueoil-butler blueoil-butler bot removed the CI: test-dlk Run dlk test once label Feb 4, 2020
@Joeper214 Joeper214 added the CI: test-blueoil Run blueoil test once label Feb 4, 2020
@blueoil-butler blueoil-butler bot removed the CI: test-blueoil Run blueoil test once label Feb 4, 2020
@Joeper214 Joeper214 added the CI: test-dlk Run dlk test once label Feb 5, 2020
@blueoil-butler blueoil-butler bot removed the CI: test-dlk Run dlk test once label Feb 5, 2020
@Joeper214 Joeper214 changed the title [WIP] Rename QTZ_linear_mid_tread_half Rename QTZ_linear_mid_tread_half Feb 5, 2020
@Joeper214 Joeper214 requested a review from primenumber February 5, 2020 09:57
@Joeper214 Joeper214 marked this pull request as ready for review February 5, 2020 09:57
@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Ownership Approval for / from iizukak, tkng, ruimashita
  • Readability Approval for Python from tkng, tsawada
  • Readability Approval for C++ from tkng, tsawada, primenumber

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python

  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

@Joeper214 Joeper214 requested a review from iizukak February 7, 2020 03:33
iizukak
iizukak approved these changes Feb 10, 2020
View reviewed changes
Copy link
Member

@iizukak iizukak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ownership Approval

primenumber
primenumber approved these changes Feb 12, 2020
View reviewed changes
Copy link
Contributor

@primenumber primenumber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RA for C++

@Joeper214 Joeper214 force-pushed the rename_QTZ_linear_mid_tread_half branch from f4d6879 to 7ccd77d Compare March 25, 2020 03:20
@Joeper214 Joeper214 added the CI: test-dlk Run dlk test once label Mar 25, 2020
@blueoil-butler blueoil-butler bot removed the CI: test-dlk Run dlk test once label Mar 25, 2020
@Joeper214 Joeper214 added the CI: test-blueoil Run blueoil test once label Mar 25, 2020
@blueoil-butler blueoil-butler bot removed the CI: test-blueoil Run blueoil test once label Mar 25, 2020
@Joeper214 Joeper214 force-pushed the rename_QTZ_linear_mid_tread_half branch from 4a48939 to 830ac9f Compare March 26, 2020 03:02
@Joeper214 Joeper214 added the CI: test-dlk Run dlk test once label Mar 26, 2020
@blueoil-butler blueoil-butler bot removed the CI: test-dlk Run dlk test once label Mar 26, 2020
@Joeper214 Joeper214 requested a review from tfujiwar March 26, 2020 09:58
tfujiwar
tfujiwar reviewed Mar 26, 2020
View reviewed changes
Copy link
Contributor

@tfujiwar tfujiwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left 1 small comment!

@Joeper214 Joeper214 force-pushed the rename_QTZ_linear_mid_tread_half branch from 18e2593 to b1deffd Compare March 26, 2020 10:35
@Joeper214 Joeper214 requested a review from tfujiwar March 26, 2020 10:36
tfujiwar
tfujiwar approved these changes Mar 26, 2020
View reviewed changes
Copy link
Contributor

@tfujiwar tfujiwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readability Approval (reverse-shadowing)

@Joeper214 Joeper214 requested review from tfujiwar and tsawada and removed request for tkng March 27, 2020 00:35
@iizukak
Copy link
Member

iizukak commented Mar 27, 2020

@Joeper214
Can you change quantizer name in the documentation?
https://docs.blue-oil.org/converter/supported_ops.html

@Joeper214
Copy link
Contributor Author

@Joeper214
Can you change quantizer name in the documentation?
https://docs.blue-oil.org/converter/supported_ops.html

Sure. I'll do that. Thanks for noticing.

tsawada
tsawada approved these changes Mar 27, 2020
View reviewed changes
Copy link
Contributor

@tsawada tsawada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readability Approval

@Joeper214
Copy link
Contributor Author

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Mar 27, 2020

⏳Merge job is queued...

@bo-mergebot bo-mergebot bot merged commit eeb6d16 into blue-oil:master Mar 27, 2020
@Joeper214 Joeper214 deleted the rename_QTZ_linear_mid_tread_half branch March 27, 2020 02:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iizukak iizukak iizukak approved these changes

@tsawada tsawada tsawada approved these changes

@primenumber primenumber primenumber approved these changes

@tfujiwar tfujiwar tfujiwar approved these changes

Assignees

@Joeper214 Joeper214

Labels
CI: auto-run Run CI automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename QTZ_binary_channel_wise_mean_scaling and other quantizers
5 participants
@Joeper214 @iizukak @tsawada @primenumber @tfujiwar