Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Experimental support for 5x5 convolution on CPU #683

Merged
merged 17 commits into from
Mar 5, 2020

Conversation

primenumber
Copy link
Contributor

@primenumber primenumber commented Dec 17, 2019

part of #475 .

Motivation and Context

5x5 convolution is desired by #435 and other networks.
Almost of all routines are already supports 5x5 convolution, but not tested well...

Description

In 5x5 convolution, maximum number of channel is limited by 436 (= floor(32767 / (5*5 * 3))).
So assertion are used to check this constraints.

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature / Optimization (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@primenumber primenumber self-assigned this Dec 17, 2019
@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Dec 17, 2019
@primenumber
Copy link
Contributor Author

How to test 5x5 conv...?
Do you have any idea? @tkng

@primenumber primenumber changed the title [WIP] Support 5x5 [WIP] Support 5x5 convolution Dec 18, 2019
@iizukak iizukak mentioned this pull request Jan 6, 2020
5 tasks
@primenumber
Copy link
Contributor Author

notice: current FPGA implementation cannot execute 5x5 conv

@primenumber primenumber changed the title [WIP] Support 5x5 convolution Experimental support for 5x5 convolution on CPU Feb 19, 2020
@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Ownership Approval for / from iizukak, tkng, ruimashita

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python
  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

@primenumber primenumber requested review from tkng and iizukak February 19, 2020 06:30
@primenumber
Copy link
Contributor Author

I gave up 5x5 conv on TCAv2 by this branch.
5x5 conv for TCAv2 may be supported later PR.

Copy link
Member

@iizukak iizukak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ownership Approval

@primenumber
Copy link
Contributor Author

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Mar 5, 2020

⏳Merge job is queued...

@bo-mergebot bo-mergebot bot merged commit 252ad87 into blue-oil:master Mar 5, 2020
@primenumber primenumber deleted the support-5x5 branch March 5, 2020 00:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI: auto-run Run CI automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants