Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Make run.py compatible with python2 #698

Merged
merged 1 commit into from
Dec 23, 2019
Merged

Make run.py compatible with python2 #698

merged 1 commit into from
Dec 23, 2019

Conversation

tfujiwar
Copy link
Contributor

time.process_time() is used in run.py but this function does not exist in Python2.

@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Dec 23, 2019
@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Ownership Approval for / from iizukak, tkng, ruimashita
  • Readability Approval for Python from tkng, tsawada

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python
  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

@tfujiwar tfujiwar requested review from kchygoe, iizukak and tkng December 23, 2019 04:02
Copy link
Member

@kchygoe kchygoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@iizukak iizukak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, python2...
Ownership Approval

Copy link
Contributor

@tkng tkng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

@tkng
Copy link
Contributor

tkng commented Dec 23, 2019

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Dec 23, 2019

⏳Merge job is queued...

@bo-mergebot bo-mergebot bot merged commit 8055a4a into blue-oil:master Dec 23, 2019
@tfujiwar tfujiwar deleted the timerfunc-py2-compatibility branch December 23, 2019 04:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI: auto-run Run CI automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants