Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

AddV2 to Add mapping (1.15.0 -> 1.14.0) #717

Merged
merged 2 commits into from
Jan 10, 2020
Merged

AddV2 to Add mapping (1.15.0 -> 1.14.0) #717

merged 2 commits into from
Jan 10, 2020

Conversation

kalpitthakkar-lm
Copy link
Contributor

@kalpitthakkar-lm kalpitthakkar-lm commented Jan 9, 2020 •
edited
Loading

Added the operator label "AddV2" for add operation as used by TF 1.15.0 in DLK_OPERATOR_MAP.

Context

Testing

  • I have locally applied the change and compiled my QuantizedResnet model successfully for DE10-Nano.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature / Optimization (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Jan 9, 2020
@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Ownership Approval for / from iizukak, tkng, ruimashita
  • Readability Approval for Python from tkng, tsawada

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python

  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

@tkng tkng self-requested a review January 9, 2020 14:06
tkng
tkng approved these changes Jan 9, 2020
View reviewed changes
Copy link
Contributor

@tkng tkng left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your first contribution to Blueoil!

Ownership Approval
Readability Approval

@tkng
Copy link
Contributor

tkng commented Jan 9, 2020

/ready

@tkng tkng added the CI: test-lmnet Run lmnet test once label Jan 9, 2020
@blueoil-butler blueoil-butler bot removed the CI: test-lmnet Run lmnet test once label Jan 9, 2020
@hadusam hadusam added the CI: test-all Run all tests once label Jan 10, 2020
@blueoil-butler blueoil-butler bot removed the CI: test-all Run all tests once label Jan 10, 2020
@tkng
Copy link
Contributor

tkng commented Jan 10, 2020

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Jan 10, 2020

⏳Merge job is queued...

@bo-mergebot bo-mergebot bot merged commit 808385e into blue-oil:master Jan 10, 2020
@kalpitthakkar-lm kalpitthakkar-lm mentioned this pull request Jan 10, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tkng tkng tkng approved these changes

Assignees
No one assigned
Labels
CI: auto-run Run CI automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kalpitthakkar-lm @tkng @hadusam