Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Change metrics JSON format from list to dict #718

Merged
merged 2 commits into from
Jan 10, 2020

Conversation

hadusam
Copy link
Contributor

@hadusam hadusam commented Jan 9, 2020

Motivation and Context

For our visualization of the benchmark results, it is better to use key/value format for metrics.

Description

Before

{
...
    "metrics": [
        {
            "name": "accuracy",
            "value": 0.0
        },
        {
            "name": "accuracy_top3",
            "value": 0.0
        },
        {
            "name": "accuracy_top5",
            "value": 0.3333333432674408
        }
    ]
}

After

{
...
    "metrics": {
        "accuracy": 0.0,
        "accuracy_top3": 0.0,
        "accuracy_top5": 0.3333333432674408
    }
}

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature / Optimization (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@hadusam hadusam requested review from suttang and iizukak January 9, 2020 14:17
@hadusam hadusam self-assigned this Jan 9, 2020
@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Jan 9, 2020
@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Ownership Approval for / from iizukak, tkng, ruimashita
  • Readability Approval for Python from tkng, tsawada

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python
  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

Copy link
Contributor

@suttang suttang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@iizukak iizukak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ownership Approval

@hadusam hadusam requested a review from tsawada January 9, 2020 23:58
Copy link
Contributor

@tsawada tsawada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readability Approval

@tkng
Copy link
Contributor

tkng commented Jan 10, 2020

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Jan 10, 2020

⏳Merge job is queued...

@bo-mergebot bo-mergebot bot merged commit 3139cb8 into blue-oil:master Jan 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI: auto-run Run CI automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants