Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Use ChHWBCl instead of HWChBCl if can #729

Merged
merged 3 commits into from
Jan 28, 2020
Merged

Use ChHWBCl instead of HWChBCl if can #729

merged 3 commits into from
Jan 28, 2020

Conversation

primenumber
Copy link
Contributor

@primenumber primenumber commented Jan 15, 2020 •
edited
Loading

quantized convolution with thresholds returns ChHWBCl tensor, but func_QTZ_linear_mid_tread_hald returns HWChBCl tensor.
This PR make both functions return ChHWBCl tensor.

Motivation and Context

Description

  • Change layouts
  • Modify pack_input to return ChHWBCl format

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature / Optimization (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@primenumber primenumber requested a review from iizukak January 15, 2020 11:15
@primenumber primenumber self-assigned this Jan 15, 2020
@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Jan 15, 2020
@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Ownership Approval for / from iizukak, tkng, ruimashita
  • Readability Approval for Python from tkng, tsawada
  • Readability Approval for C++ from tkng, tsawada

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python

  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

@primenumber primenumber added the CI: test-lmnet Run lmnet test once label Jan 16, 2020
@blueoil-butler blueoil-butler bot removed the CI: test-lmnet Run lmnet test once label Jan 16, 2020
@iizukak iizukak requested a review from tkng January 20, 2020 02:06
@primenumber primenumber mentioned this pull request Jan 23, 2020
Closed
5 tasks
iizukak
iizukak approved these changes Jan 24, 2020
View reviewed changes
Copy link
Member

@iizukak iizukak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ownership Approval

@iizukak
Copy link
Member

iizukak commented Jan 27, 2020

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Jan 27, 2020

⏳Merge job is queued...

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Jan 27, 2020

😱Something went wrong. Please contact administrators.

@primenumber
Copy link
Contributor Author

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Jan 27, 2020

⏳Merge job is queued...

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Jan 27, 2020

😱Something went wrong. Please contact administrators.

@tfujiwar tfujiwar changed the title Use ChHWBCl instead of HWChBCl if can [WIP] Use ChHWBCl instead of HWChBCl if can Jan 27, 2020
@tfujiwar tfujiwar changed the title [WIP] Use ChHWBCl instead of HWChBCl if can Use ChHWBCl instead of HWChBCl if can Jan 27, 2020
@tfujiwar
Copy link
Contributor

@iizukak @primenumber Let me check the problem of mergebot. But this PR needs Python readability review anyway.

tkng
tkng reviewed Jan 27, 2020
View reviewed changes
Copy link
Contributor

@tkng tkng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than small comments, LGTM. Could you insert some spaces?

@tkng tkng self-requested a review January 28, 2020 03:23
tkng
tkng approved these changes Jan 28, 2020
View reviewed changes
Copy link
Contributor

@tkng tkng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ownership Approval
Readability Approval

@tkng
Copy link
Contributor

tkng commented Jan 28, 2020

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Jan 28, 2020

⏳Merge job is queued...

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Jan 28, 2020

😱Something went wrong. Please contact administrators.

@tfujiwar
Copy link
Contributor

tfujiwar commented Jan 28, 2020 •
edited
Loading

@primenumber Sorry for the inconvenience. I don't know why but MergeBot has no permission to update this PR's branch (not only MergeBot but also developers other than you cannot update the branch...). Could you update the branch and merge this PR manually?

@primenumber
Copy link
Contributor Author

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Jan 28, 2020

⏳Merge job is queued...

@primenumber
Copy link
Contributor Author

Oh, Allow edits from maintainers. was disabled for some reason...

@tfujiwar
Copy link
Contributor

@primenumber Thank you!! I didn't know about Allow edits from maintainers.

@bo-mergebot bo-mergebot bot merged commit 67fdada into blue-oil:master Jan 28, 2020
@primenumber primenumber deleted the remove-hwchbcl branch January 28, 2020 03:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tkng tkng tkng approved these changes

@iizukak iizukak iizukak approved these changes

Assignees

@primenumber primenumber

Labels
CI: auto-run Run CI automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@primenumber @iizukak @tfujiwar @tkng