Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Create .jenkins directory #75

Merged
merged 8 commits into from
Dec 25, 2018
Merged

Conversation

hadusam
Copy link
Contributor

@hadusam hadusam commented Dec 12, 2018

Create .jenkins directory for test scripts run by Jenkins

Motivation and Context

Currently, we cannot see the test scripts and change them without changing Jenkins settings.
Sometimes we need to change test commands according to the source codes changing.
This PR will make debugging and improving tests easy.

Description

  • Create .jenkins directory
  • Put scripts for Jenkins (test_blueoil.sh, test_lmnet.sh, test_dlk.sh)
  • Create README.md for jenkins and write information about tests run by Jenkins

How has this been tested?

GPU part

Clone this branch on GPU server which has 4 GPUs and run following commands at the same time.
./.jenkins/test_blueoil.sh
./.jenkins/test_lmnet.sh
Make it sure that tests were run and succeeded.

FPGA part

Clone this branch on local Jenkins (jenkins.leapmind.local), and run following command.
./.jenkins/test_dlk.sh
Make it sure that tests were run and succeeded.

Screenshots:

  • Result of blueoil test
    image
  • Result of lmnet test
    image
  • Result of dlk test
    image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature / Optimization (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

To Do before Merge

  • Review and approve this PR.
  • Change current Jenkins settings as following
  • Script for blueoil test : ./.jenkins/test_blueoil.sh
  • Script for lmnet test : ./.jenkins/test_lmnet.sh
  • Script for dlk test : ./.jenkins/test_dlk.sh
  • Re-run all tests of this PR
  • Make sure all tests are passed

To Do after Merge

  • Re-run all tests of all PRs (we don't need to do actively, because all PRs will be outdated, so tests will be run by each PR's merge cycle)

@hadusam hadusam added the enhancement New feature or request label Dec 12, 2018
@hadusam hadusam self-assigned this Dec 12, 2018
Copy link
Contributor

@ruimashita ruimashita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Please add url link to .jenkins/README.md intoREADME.md.

others, LGTM

@hadusam
Copy link
Contributor Author

hadusam commented Dec 14, 2018

@ruimashita
Thank you for your review, I added the link to README.md of Jenkins.
Please check https://github.com/hadusam/blueoil/tree/create_jenkins_dir#tests-for-ci

@hadusam
Copy link
Contributor Author

hadusam commented Dec 25, 2018

Change current Jenkins settings as following

I updated all settings of tests. So, I will re-run all tests.

@hadusam
Copy link
Contributor Author

hadusam commented Dec 25, 2018

All tests are passed!
I merge this PR.

@hadusam hadusam merged commit ddbb5b8 into blue-oil:master Dec 25, 2018
@hadusam hadusam deleted the create_jenkins_dir branch December 25, 2018 15:16
ruimashita pushed a commit that referenced this pull request Jun 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants