Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Change device buf type #767

Merged
merged 4 commits into from
Jan 29, 2020

Conversation

primenumber
Copy link
Contributor

Motivation and Context

device_output_buf has type BIN_CONV_OUTPUT, but the buf may contain values which has type QUANTIZED_PACKED.

device_input_buf and device_output_buf should contain only address information, so its type should be void* or similar type.

Description

  • print_device_output_buf is no longer used and useless for now, so removed it.

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature / Optimization (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@primenumber primenumber requested a review from iizukak January 28, 2020 09:28
@primenumber primenumber self-assigned this Jan 28, 2020
@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Jan 28, 2020
@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Ownership Approval for / from iizukak, tkng, ruimashita

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python
  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

Copy link
Contributor

@tkng tkng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ownership Approval
Readability Approval

Can I skip readablity approval? I'm not sure...

@tkng
Copy link
Contributor

tkng commented Jan 29, 2020

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Jan 29, 2020

⏳Merge job is queued...

@bo-mergebot bo-mergebot bot merged commit ee960f7 into blue-oil:master Jan 29, 2020
@primenumber primenumber deleted the change-device-buf-type branch January 29, 2020 03:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI: auto-run Run CI automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants