Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Remove scripts using darknet pretrained models #783

Merged
merged 5 commits into from
Feb 8, 2020
Merged

Remove scripts using darknet pretrained models #783

merged 5 commits into from
Feb 8, 2020

Conversation

iizukak
Copy link
Member

@iizukak iizukak commented Feb 3, 2020

Solve #781
Please review after #782 merged

@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Feb 3, 2020
@iizukak iizukak added the CI: test-all Run all tests once label Feb 3, 2020
@blueoil-butler blueoil-butler bot removed the CI: test-all Run all tests once label Feb 3, 2020
@iizukak iizukak changed the title [WIP] Remove scripts using darknet pretrained models Remove scripts using darknet pretrained models Feb 3, 2020
@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Readability Approval for Python from tkng, tsawada

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python

  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

@iizukak
Copy link
Member Author

iizukak commented Feb 6, 2020

@tkng please review.

@tkng
Copy link
Contributor

tkng commented Feb 6, 2020

I'm not sure that we should remove these config files. Could you tell me your opinion?

@iizukak
Copy link
Member Author

iizukak commented Feb 6, 2020

@tkng
I haven't seen anyone using this feature after Blueoil v0.1 released.
I want to remove useless code for reduce maintenance cost.

@iizukak
Copy link
Member Author

iizukak commented Feb 6, 2020

But in this case, should is too strong word, maybe...

@tkng
Copy link
Contributor

tkng commented Feb 6, 2020

OK, let's remove. (Personally, I used these files sometimes... but it's OK, I can copy these files to other directory before git pull.)

@tkng
Copy link
Contributor

tkng commented Feb 6, 2020

Ownership Approval
Readability Approval

@tkng
Copy link
Contributor

tkng commented Feb 6, 2020

/ready

@iizukak
Copy link
Member Author

iizukak commented Feb 6, 2020

Personally, I used these files sometimes...

Wow, really, I don't know that...

@iizukak
Copy link
Member Author

iizukak commented Feb 7, 2020

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Feb 7, 2020

⏳Merge job is queued...

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Feb 7, 2020

😥Not mergeable. Please fix problems and send /ready again.

@iizukak
Copy link
Member Author

iizukak commented Feb 7, 2020

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Feb 7, 2020

⏳Merge job is queued...

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Feb 7, 2020

😥Not mergeable. Please fix problems and send /ready again.

@hadusam hadusam self-requested a review February 7, 2020 08:27
hadusam
hadusam approved these changes Feb 7, 2020
View reviewed changes
Copy link
Contributor

@hadusam hadusam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iizukak iizukak merged commit d6f2af0 into blue-oil:master Feb 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hadusam hadusam hadusam approved these changes

Assignees
No one assigned
Labels
CI: auto-run Run CI automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iizukak @tkng @hadusam