Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Unify tensor name #829

Merged
merged 4 commits into from
Feb 18, 2020
Merged

Conversation

primenumber
Copy link
Contributor

Motivation and Context

Currently, tensor naming in dlk runtime is op.name or op.name + '_' + out_k.
latter naming is used if op has multiple output.
This PR unify naming to op.name + '_' + out_k.

Description

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature / Optimization (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@primenumber primenumber requested review from tkng and iizukak February 12, 2020 08:05
@primenumber primenumber self-assigned this Feb 12, 2020
@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Feb 12, 2020
@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Ownership Approval for / from iizukak, tkng, ruimashita
  • Readability Approval for Python from tkng, tsawada

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python
  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

Copy link
Member

@iizukak iizukak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ownership Approval

@primenumber primenumber requested a review from tsawada February 14, 2020 08:36
Copy link
Contributor

@tsawada tsawada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readability Approval

@primenumber
Copy link
Contributor Author

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Feb 18, 2020

⏳Merge job is queued...

@bo-mergebot bo-mergebot bot merged commit 2d134b7 into blue-oil:master Feb 18, 2020
@primenumber primenumber deleted the unify-tensor-name branch February 18, 2020 04:49
@primenumber primenumber mentioned this pull request Mar 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI: auto-run Run CI automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants