Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Move lmnet/lmnet/data_processor.py to blueoil/data_processor.py #832 #835

Merged
merged 6 commits into from
Feb 13, 2020
Merged

Move lmnet/lmnet/data_processor.py to blueoil/data_processor.py #832 #835

merged 6 commits into from
Feb 13, 2020

Conversation

iizukak
Copy link
Member

@iizukak iizukak commented Feb 13, 2020

What this patch does to fix the issue.

  • Move lmnet/lmnet/data_processor.py to blueoil/data_processor.py
  • Change import paths

Link to any relevant issues or pull requests.

This PR is a part of #796

@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Feb 13, 2020
@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Readability Approval for Python from tkng, tsawada

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python

  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

odoku
odoku approved these changes Feb 13, 2020
View reviewed changes
Copy link
Contributor

@odoku odoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

suttang
suttang approved these changes Feb 13, 2020
View reviewed changes
Copy link
Contributor

@suttang suttang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits

lmnet/tests/lmnet_tests/networks_tests/object_detection_tests/test_yolo_v2.py Outdated
@@ -19,9 +19,9 @@
from easydict import EasyDict

from executor.train import start_training
from blueoil.data_processor import Sequence
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you change the line?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I fix conflict, This line changed accidentally.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@suttang change reverted.

lmnet/tests/lmnet_tests/networks_tests/segmentation_tests/test_lm_bisenet.py Outdated
@@ -19,9 +19,9 @@
from easydict import EasyDict

from executor.train import start_training
from blueoil.data_processor import Sequence
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same (change line)

@iizukak iizukak requested a review from tsawada February 13, 2020 07:07
tsawada
tsawada approved these changes Feb 13, 2020
View reviewed changes
Copy link
Contributor

@tsawada tsawada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readability Approval

@iizukak
Copy link
Member Author

iizukak commented Feb 13, 2020

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Feb 13, 2020

⏳Merge job is queued...

@bo-mergebot bo-mergebot bot merged commit 6d69f41 into blue-oil:master Feb 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@suttang suttang suttang approved these changes

@odoku odoku odoku approved these changes

@tsawada tsawada tsawada approved these changes

@tfujiwar tfujiwar Awaiting requested review from tfujiwar

Assignees
No one assigned
Labels
CI: auto-run Run CI automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iizukak @suttang @odoku @tsawada