Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Fix is_scalar #869

Merged
merged 4 commits into from
Mar 2, 2020
Merged

Fix is_scalar #869

merged 4 commits into from
Mar 2, 2020

Conversation

primenumber
Copy link
Contributor

What this patch does to fix the issue.

Fix Operator::is_scalar function.

Link to any relevant issues or pull requests.

@primenumber primenumber added the bug Something isn't working label Feb 20, 2020
@primenumber primenumber self-assigned this Feb 20, 2020
@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Feb 20, 2020
@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Ownership Approval for / from iizukak, tkng, ruimashita
  • Readability Approval for Python from tkng, tsawada

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python

  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

@tsawada tsawada removed their request for review February 21, 2020 10:55
@tsawada
Copy link
Contributor

tsawada commented Feb 21, 2020

Please get ownership approval and lgtm first.

@primenumber primenumber added the CI: test-dlk Run dlk test once label Feb 21, 2020
@blueoil-butler blueoil-butler bot removed the CI: test-dlk Run dlk test once label Feb 21, 2020
iizukak
iizukak approved these changes Feb 26, 2020
View reviewed changes
Copy link
Member

@iizukak iizukak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ownership Approval

tsawada
tsawada approved these changes Feb 26, 2020
View reviewed changes
Copy link
Contributor

@tsawada tsawada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readability Approval

@iizukak
Copy link
Member

iizukak commented Mar 2, 2020

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Mar 2, 2020

⏳Merge job is queued...

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Mar 2, 2020

😥Status check failed. Please fix problems and send /ready again.

@tfujiwar
Copy link
Contributor

tfujiwar commented Mar 2, 2020

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Mar 2, 2020

⏳Merge job is queued...

@bo-mergebot bo-mergebot bot merged commit 8897246 into blue-oil:master Mar 2, 2020
@primenumber primenumber deleted the fix-scalar-check branch March 24, 2020 16:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iizukak iizukak iizukak approved these changes

@tsawada tsawada tsawada approved these changes

Assignees

@primenumber primenumber

Labels
bug Something isn't working CI: auto-run Run CI automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@primenumber @tsawada @iizukak @tfujiwar