-
Notifications
You must be signed in to change notification settings - Fork 86
Run tests as user #870
Run tests as user #870
Conversation
This PR needs Approvals as follows.
Please choose reviewers and requet reviews! Click to see how to approve each reviewsYou can approve this PR by triggered comments as follows.
See all trigger commentsPlease replace [Target] to review target
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ownership Approval
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Now docker option can be --gpus=
. It would be discussed later
/ready |
⏳Merge job is queued... |
What this patch does to fix the issue.
In the default, docker run as root user and the permission of artifacts created by docker is
root:root
. This prevents some users and CI agents to clean up artifacts generated by tests.So I changed to run tests as user permission by adding docker option.
Link to any relevant issues or pull requests.