Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Run tests as user #870

Merged
merged 5 commits into from
Feb 21, 2020
Merged

Conversation

hadusam
Copy link
Contributor

@hadusam hadusam commented Feb 20, 2020

What this patch does to fix the issue.

In the default, docker run as root user and the permission of artifacts created by docker is root:root. This prevents some users and CI agents to clean up artifacts generated by tests.
So I changed to run tests as user permission by adding docker option.

Link to any relevant issues or pull requests.

@hadusam hadusam self-assigned this Feb 20, 2020
@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Feb 20, 2020
@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Ownership Approval for / from iizukak, tkng, ruimashita

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python
  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

@hadusam hadusam changed the title Run tests as user permission Run tests as user Feb 20, 2020
Copy link
Member

@iizukak iizukak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ownership Approval

Copy link
Member

@kchygoe kchygoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Now docker option can be --gpus=. It would be discussed later

@hadusam
Copy link
Contributor Author

hadusam commented Feb 21, 2020

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Feb 21, 2020

⏳Merge job is queued...

@bo-mergebot bo-mergebot bot merged commit 6190ab5 into blue-oil:master Feb 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI: auto-run Run CI automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants